On Wed, Nov 05, 2008 at 09:59:25AM -0800, Suraj N. Kurapati wrote: > Allows the user to answer 'Stage this hunk' questions with a > single keypress, just like in Darcs. Previously, the user was > forced to press the Return key after every choice they made. > This quickly becomes tiring, burdensome work for the fingers. I think this is a reasonable goal, but I have a few questions/concerns. - There are three versions of your patch, but nobody has commented. Clearly we can see what changed, but it is not clear what advantage one patch has over the other. Care to elaborate? - Term::ReadKey, while common, is not part of base perl. So I think using it needs to be conditional, and on systems without it we can degrade to the current behavior. - There's no facility in your patch for restoring the terminal if we break out of the loop in an unexpected way (e.g., via the user hitting ^C). - This only enhances one particular input, the patch loop. It is probably worth being consistent and allowing these behavior for other menus (though the numeric inputs are a bit trickier). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
