On Fri, 31 Oct 2008, Shawn O. Pearce wrote: > I'm tempted to stick with int for the result type, but I don't > want readers to confuse our result type of 0 == success, <0 == > failure with some case where we return a signed integral value as > a result of a computation. Does this actually happen ? > I'm also debating the error handling. Do we return the error > code as the return value from the function, or do we stick it into > some sort of thread-global like classic "errno", or do we ask the > application to pass in a structure to us? Passing a structure pointer for errors is adding overhead to the API in all cases, please don't do that. Both the negative code and errno style are lightweight in the common "no error" case. The errno style is probably more handy for those functions returning a pointer which should be NULL in the error case. Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
