On Sun, Oct 26, 2008 at 10:30:48PM -0700, Junio C Hamano wrote: > > But it makes me a little nervous. On one hand, I think it is definitely > > the right thing for "status -v" to respect user options. But we do > > several _other_ diffs in addition, and those are more "plumbing" diffs. > > I think they should probably at least have diff_basic_config (e.g., for > > rename limits). But we are applying the diff_ui_config options to all > > diffs. Looking over the available options, I _think_ there are no nasty > > surprises. But you never know. > > Up to 6/8 are indisputably good changes. The next one means well, and > this one is a requisite step for it, but I agree that this feels somewhat > risky. I have to wonder that nobody ever complained about the lack of diff config here before. If I ever used "git status -v", I would certainly have been turned off by the lack of color. But maybe everybody is using "git commit -v" and their editor is colorizing it. Or maybe they just aren't using color (the only other noticeable thing would be rename options). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
