On Tue, Oct 21, 2008 at 07:02:48PM +0200, Johannes Schindelin wrote: > So I propose this change in semantics: > > - setup_git_directory_gently(): rename to discover_git_directory(), > and avoid any chdir() at all. > - setup_git_directory(): keep the semantics that it chdir()s to the > worktree, or to the git directory for bare repositories. > > Using _gently() even for RUN_SETUP builtins should solve the long standing > pager problem, too. I'm not sure there aren't hidden problems lurking in that strategy (every time I look at this area of code, something unexpected prevents what I think should Just Work from Just Working), but I think that is a promising direction to go for clearing up some of the long-standing issues. I think you will need to do something for a few commands which use _gently() but then, if we _are_ in a git repo, assume we are chdir'd properly. We may also be able to just call setup_git_directory_gently() as the first thing in the wrapper, which should help us more consistently find config before the 'exec' stage (see 4e10738a for a discussion of some of the issues). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
