Hi, On Tue, 21 Oct 2008, Nguyen Thai Ngoc Duy wrote: > Maybe we should let setup_*_gently() do read-only stuff only and let its > consumers to handle cwd. I think that makes sense. This would allow setup*gently() to be much cleaner, and only setup_git_directory() itself would do the chdir(worktree). However, let's think this really through this time, so that that darned worktree stuff is fixed for good. So I propose this change in semantics: - setup_git_directory_gently(): rename to discover_git_directory(), and avoid any chdir() at all. - setup_git_directory(): keep the semantics that it chdir()s to the worktree, or to the git directory for bare repositories. Using _gently() even for RUN_SETUP builtins should solve the long standing pager problem, too. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
