On Sun, Oct 12, 2008 at 01:10:01AM -0700, Junio C Hamano wrote: > One thing to keep in mind is what to do when you would want to detect > renames. The parallel walk would be Ok but between HEAD and index there > could be renames involved, and at that point it would get quite tricky. > Once the index is in-core, I think it hurts us much to walk HEAD vs index > and index vs working tree in separate passes. Assuming you meant "I _don't_ think it hurts us much" then OK, that makes sense. I was just thinking it would be more elegant than holding each list in memory and comparing, but really that is not all that different than what diffcore does with the output queue. > I think it is perfectly fine to run the diff-index first, and keep the > result from it in a string_list, and then run "diff-files" and annotate > the string_list with the output from it. Thanks, I think that is a sane direction to go in. And I agree that any solution should be totally split from the actual output format, so we can reuse it in "git status" if desired. However, now that Shawn has revealed the existence of his super-secret status replacement, I am going to wait to see that before moving any further. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
