On Sun, Oct 12, 2008 at 02:58:20AM -0700, Junio C Hamano wrote:
> > + fd = hold_locked_index(&index_lock, 0);
> > + if (fd < 0) {
> > + if (!status_only)
> > + die("unable to lock index: %s",
> > + strerror(errno));
> > + return get_index_file();
> > + }
> > refresh_cache(REFRESH_QUIET);
>
> You would probably want to refresh_cache() here even if you are not going
> to write the resulting index out, so that you won't show the stat-only
> differences to the end user. Other than that, I think this is a good
> change.
That is a good point. However, I think this change is still not a good
one, because it is only halfway there. It makes "git status" work, but
not "git status path", which wants to write out the resulting cache. I
don't know what complications are involved with making that work.
Probably there is a way, but I haven't looked too closely, as I think a
better path forward is a new tool that is not so closely tied to commit.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
