On Fri, Oct 3, 2008 at 12:41 AM, Jakub Narebski <jnareb@xxxxxxxxx> wrote: > Petr Baudis wrote: >> On Thu, Oct 02, 2008 at 11:05:18PM +0200, Giuseppe Bilotta wrote: >> > >> > In preparing the new patchset, I've put a big comment block explaining >> > why we need to set both $hash and $hash_base in this code-path: >> > >> > # we got "project.git/[action/]branch". in this case >> > # we set both $hash and $hash_base because different actions >> > # need one or the other to be set to behave correctly. >> > # >> > # For example, if $hash_base is not set then the blob and > > 'blob' without $file_name doesn't have sense, but 'tree' does. > Probably should be s/blob/tree/ above. > >> > # history links on the page project.git/tree/somebranch will >> > # assume a $hash_base of HEAD instead of the correct >> > # somebranch. Note: the blob and history links _in a tree page_ are wrong. The page itself is correct. What this means is that if you go to project.git/tree/somebranch you get the correct list of files and directories for the project at somebranch's HEAD, but all the links IN that page will point to the wrong version, because they will have no $hash_base set and will thus default to HEAD. You can see this effect for example by going to http://repo.or.cz/w/git.git/v1.4.0?a=tree <- this hand-crafted path would never be generated by the old pathinfo code, but it show exactly what would happen with my pahtinfo code on http://repo.or.cz/w/git.git/tree/v1.4.0 if $hash_base wasn't set. -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
