On Thu, Oct 02, 2008 at 11:05:18PM +0200, Giuseppe Bilotta wrote: > In preparing the new patchset, I've put a big comment block explaining > why we need to set both $hash and $hash_base in this code-path: > > # we got "project.git/[action/]branch". in this case > # we set both $hash and $hash_base because different actions > # need one or the other to be set to behave correctly. > # > # For example, if $hash_base is not set then the blob and > # history links on the page project.git/tree/somebranch will > # assume a $hash_base of HEAD instead of the correct > # somebranch. > # Conversely, not setting $hash will make URLs such as > # project.git/shortlog/somebranch display the wrong page. > # > # Since it also turns out that the unused one is properly > # overwritten as needed, setting both is quite safe. Ok, but is this related to the pathinfo changes? Or is this fixing a separate bug? (Not that I would want to bother you with splitting this, but you should at least mention it in the commit message... and it's fairly isolated anyway.) -- Petr "Pasky" Baudis People who take cold baths never have rheumatism, but they have cold baths. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
