onsdagen den 1 oktober 2008 16.37.18 skrev Shawn O. Pearce: > Robin Rosenberg <robin.rosenberg@xxxxxxxxxx> wrote: [..] > I think this is wrong. Any color that we get from [...] > What was the rationale for disposing of these resources? Did you > identify that this is a resource leak somewhere? Because I'd like > to make sure I actually understand the SWT resource model better > so I don't commit mistakes in the future. I read the Color javadoc, but not the getSystemColor one. You are right, drop this patch and the "dispose" hunk in the next patch (which was also a -- robin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html