Re: [PATCH 4/4] diff.c: convert builtin funcname patterns to extended regular expressions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Brandon Casey wrote:
Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx>
---


This is a blind conversion removing \\ before ( and { etc.
and adding \\ before naked ( and { etc.

I hope the authors who last touched these patterns will help with testing:

bibtex: Johan Herland
  html: Johan Herland
  java: Junio Hamano, Jeff King
pascal: Avery Pennarun
   php: Andreas Ericsson
python: Kirill Smelkov
  ruby: Giuseppe Bilotta
   tex: Johan Herland


The PHP one seems to work just fine.

Signed-off-by: Andreas Ericsson <ae@xxxxxx>

Nicely done, although I'd rather have "ereg_funcname" instead of
"xfuncname", but I don't care very much for myself, as I'll
rather submit my patterns upstream than add them to .git/config ;-)

Junio:
Can we issue a deprecation heads-up for the current "funcname"
along with a "call for patterns" and then have "funcname" and
"ereg_funcname" mean the same for a while until we obsolete
ereg_funcname in favour of funcname, perhaps? I can't imagine
anyone wanting to use posix regular expressions if extended
ones are available everywhere.

--
Andreas Ericsson                   andreas.ericsson@xxxxxx
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux