Re: [PATCH 1/2] add '%d' pretty format specifier to show decoration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 03, 2008 at 01:59:17PM -0700, Junio C Hamano wrote:

> > Isn't that what you argued against in Dscho's version of the patch?
> >
> >     http://mid.gmane.org/7v1w5exfwb.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx
> 
> Yeah, but unlike Linus, I am not infallible.  Also, I can change my mind.

Heh. OK, I am not against you changing your mind, but I like to at least
see "...and here is what is different." So thank you.

I think adding the space to the parentheses makes the most sense.
Without more advanced syntax, we have to make a choice between doing too
much (e.g., adding parentheses when the user doesn't want it) and too
little (the user has to put in parentheses manually, which means they
are there whether there is decoration or not). Doing parentheses
_without_ the space means we fail at both. So let us at least get it
half right. ;)

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux