Jeff King <peff@xxxxxxxx> writes: >> git log --pretty=format:'%H (%d) %s' > > I think Junio requested the enclosing parentheses be included. I am not > sure I agree, but we are already mandating the comma separator. > Personally, I think the right solution is more like > > %(decorate:delim=, ) > > but that is a much bigger change (and part of what was holding me up on > just improving this patch). I think adding %d in the meantime (with or > without the surrounding parentheses) is reasonable. I agree with the above reasoning. If we go with surrounding parentheses, it might even make sense to include a SP _before_ the opening parenthesis, so that "%h %s%d" expands to either of these: $ git show -s --pretty=format:'%h %s%d' v1.6.0^0 v1.6.0^1 ea02eef GIT 1.6.0 (refs/tags/v1.6.0) 373a273 Merge git-gui 0.11.0 Also I did not like the bug to misidentify "git log --grep=pretty=format:" you pointed out in your message. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
