On Wed, Sep 03, 2008 at 10:06:45PM +0200, Michael Dressel wrote: > I'm sorry for not properly citing you. I did mention you in the commit > message which is wrong. So what would be the right way? Just adding a > line Signed-off-by: Jeff King <peff@xxxxxxxx> > before the ---? > Or resending your original patch and than my patch on top of yours? Oh, you cited me just fine. The Signed-off-by line isn't for credit; it indicates that you agree to the Developer's Certificate of Origin. IOW, it says "I wrote this (or I know who did) and I know it can be licensed for the project". So what I was saying was not "oh, you didn't credit me properly" but rather "you may also add to the official record that the parts I wrote are fine to be GPL'd for the project." So in this case, I would simply add my Signed-off-by to the commit message when you resend the patch. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
