On Wed, Sep 3, 2008 at 17:18, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote: > Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote: >> Try to shorten the refname to a non-ambiguous name. >> >> Changes in v3: >> * don't compare sha1's, its ambiguous if the short name >> resovles to more than one ref >> * use xstrdup() >> * use indexes for the loops to clarify backward/forward >> direction >> >> >> Signed-off-by: Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> >> Cc: git@xxxxxxxxxxxxxxx >> Cc: szeder@xxxxxxxxxx >> Cc: Shawn O. Pearce <spearce@xxxxxxxxxxx> >> --- > > Looks good. But the commit messages shouldn't have the "Changes > in v3" section or probably the "Cc:" lines. The changes in v3 > part usually goes below the ---. Ok, but shouldn't git format-patch detect that there is already a --- in the commit message, or is it illegal to have more than one ---? And while we are at it, shouldn't git format-patch detect, that there is already a [*PATCH*]-prefix in the first line of the commit? I always need to edit these two things after format-patch. Bert > > -- > Shawn. > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
