Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote: > Try to shorten the refname to a non-ambiguous name. > > Changes in v3: > * don't compare sha1's, its ambiguous if the short name > resovles to more than one ref > * use xstrdup() > * use indexes for the loops to clarify backward/forward > direction > > > Signed-off-by: Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> > Cc: git@xxxxxxxxxxxxxxx > Cc: szeder@xxxxxxxxxx > Cc: Shawn O. Pearce <spearce@xxxxxxxxxxx> > --- Looks good. But the commit messages shouldn't have the "Changes in v3" section or probably the "Cc:" lines. The changes in v3 part usually goes below the ---. I don't usually work on for-each-ref, but I'll toss an ack in anyway: Acked-by: Shawn O. Pearce <spearce@xxxxxxxxxxx> -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html