On Tue, Sep 02, 2008 at 04:55:39PM -0700, Junio C Hamano wrote: > realized that I forgot to mention one thing. > > The name. > > "filedirstat" is simply too long to type, and it has a certain "Huh?" > factor --- is it about file, or is it about directory? > > This option essentially is just the dirstat but with different logic to > compute how big the damage is. Conceptually, the original one gives one > "damage point" to each added or deleted line. > > $ git show --dirstat=<one-point-per-line> > > and yours awards one point to each file, whatever the size of the damage > is. > > $ git show --dirstat=<one-point-per-file> > > I cannot come up with a short-and-sweet name for one-point-per-X offhand, > but expressing this variant as an option to --dirstat will leave the door > open for other people to come up with different system to award damage > points. Perhaps > > $ git show --dirstat=exclude-typofixes > > might even be not just interesting but useful ;-) I wouldn't add new semantics for --dirstat=x since it's easy to add new options. We already have --cumulative, so adding options is not new. How about "--dirstat --filemode"? It's long, but it is obvious. I don't think length is relevant here. A shorter but obscure syntax would be "--dirstat2" :-) -- Heikki Orsila heikki.orsila@xxxxxx http://www.iki.fi/shd -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
