On Mon, Sep 01, 2008 at 11:57:46PM -0700, Junio C Hamano wrote:
> Heikki Orsila <heikki.orsila@xxxxxx> writes:
>
> > @@ -2474,7 +2478,10 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)
> > options->output_format |= DIFF_FORMAT_DIRSTAT;
> > else if (!strcmp(arg, "--cumulative"))
> > options->output_format |= DIFF_FORMAT_CUMULATIVE;
> > - else if (!strcmp(arg, "--check"))
> > + else if (opt_arg(arg, 'X', "filedirstat", &options->dirstat_percent)) {
> > + options->output_format |= DIFF_FORMAT_DIRSTAT;
> > + options->filedirstat = 1;
>
> Why 'X'? It would never match, confusing to the reader, and risks a
> sudden change in behaviour when these statements are reordered or somebody
> mechanically attempts to convert this to parse_options().
This is embarrassing.. I just copied the previous "dirstat" line..
*grin*
Anyway, what about the concept of filedirstat? Is it agreeable?
--
Heikki Orsila
heikki.orsila@xxxxxx
http://www.iki.fi/shd
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
