Jeff King <peff@xxxxxxxx> writes: > On Sat, Aug 30, 2008 at 07:39:47PM +0200, Robert Schiele wrote: > >> git-add--interactive has one Perl command that was not yet present in >> Perl 5.6. Changing this single command makes it compatible again. > > Having read your other message, I know what it is about this command > that does not work with Perl 5.6. But probably it would be good to > mention "list form of three argument open with pipe". > >> git-add--interactive.perl | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > What about the similar uses in cvsimport, cvsserver, and gitweb? How > about the scripts in contrib (a quick grep reveals some fast-import > scripts, blameview, cidaemon, continuous, and hooks/update-paranoid. > > Most of those things are not as "core" as add--interactive, so I am not > opposed to changing just this one spot and documenting "core can use > 5.6, but these other things need 5.8". > >> - open($fh, '-|', @_) or die; >> + open($fh, '-|', join(' ', @_)) or die; > > Won't this execute the command using the shell, which means that > metacharacters need to be escaped? I didn't try, but I'm pretty sure > this would break > > git add -i "file with space" I didn't try either but I think you are right. And I agree we should say we rely on 5.6 or newer. I thought gitweb folks are targetting 5.6.1 as the minimum for unicode support (Lea and Jakub Cc'ed)? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html