On Tue, 19 Aug 2008, Jeff King wrote: > On Mon, Aug 18, 2008 at 08:22:19PM -0700, Junio C Hamano wrote: > > > I do not know if I like the end result, but here is a patch to make the > > traditional a/ and b/ prefix more mnemonic. > > Hmm. Something deep in my gut doesn't like this, just because I like the > fact that no matter how I prepare a diff (and I do tend to do it > different ways and post to the mailing list) it always ends up the same. > For example, I sometimes "hand-generate" patch messages meant to be > applied by git-am by doing a diff between the working tree and index and > pasting the result into an email. It just feels a bit wrong for it not > to be the exact output I would get from commiting and running > format-patch. Hmm... everybody who doesn't like it is concerned about scripts and sending it places, while the people who like it seem to be interested in looking at the output. Maybe there should be an option that controls it, with the default being to use -a+b for pipelines and informational stuff for pager? It seems to me like, in output for user consumption, the information is useful, while in output for non-user consumption, the information is overly personal. But that's easy enough to detect... (For that matter, maybe format-patch should be able to handle uncommitted changes, and should hide what it did? What's with all these people faking format-patch output with other commands, rather than having format-patch actually generate suitable output in their situations?) -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
