Marcus Griep <marcus@xxxxxxxx> wrote:
> Eric Wong wrote:
> > Thank you Marcus!
> >
> > Acked-by: Eric Wong <normalperson@xxxxxxxx>
>
> Errr, you want to Ack [PATCH v2 3/3]; not this one; there's one minor
> typo when I shortened the variable $result to $res.
>
> >> + my $res;
> >> + while ($res = sysread($fh, my $str, 1024)) {
> >> + my $out = syswrite($tmp_fh, $str, $res);
> >> + defined($out) && $out == $res
> >> + or croak("write ",
> >> + $tmp_fh->filename,
> >> + ": $!\n");
> >> + }
> >> + defined $result or croak $!;
>
> That last line causes compilation errors with 'use strict'. It is fixed
> in the alternate version.
Oops, I applied the right patch but managed to reopen the wrong one when
I acked it.
I've just pushed out my repository with acks to
git://bogomips.org/git-svn.git
--
Eric Wong
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
