Re: [PATCH 3/3] git-svn: Reduce temp file usage when dealing with non-links

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Wong wrote:
> Thank you Marcus!
> 
> Acked-by: Eric Wong <normalperson@xxxxxxxx>

Errr, you want to Ack [PATCH v2 3/3]; not this one; there's one minor
typo when I shortened the variable $result to $res.

>> +				my $res;
>> +				while ($res = sysread($fh, my $str, 1024)) {
>> +					my $out = syswrite($tmp_fh, $str, $res);
>> +					defined($out) && $out == $res
>> +						or croak("write ",
>> +							$tmp_fh->filename,
>> +							": $!\n");
>> +				}
>> +				defined $result or croak $!;

That last line causes compilation errors with 'use strict'.  It is fixed
in the alternate version.

-- 
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux