On Wed, Jul 30, 2008 at 01:07:15AM -0400, Jeff King wrote:
> > - die("no commit message? aborting commit.");
> > + die("no commit message. aborting commit.");
>
> I don't think the change of punctuation makes a big difference here,
> but this could probably stand to be reworded. Maybe:
>
> Aborting commit due to empty commit message.
Using "die" also prepends "fatal: " which is perhaps a bit much for an
expected feature. So maybe:
fprintf(stderr, "Aborting commit due to empty commit message.\n");
exit(1); /* or even some specific "intentional abort" exit code */
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
