Shawn O. Pearce wrote:
> SZEDER GGGbor <szeder@xxxxxxxxxx> wrote:
> > > _git_describe ()
> > > {
> > > + __git_has_doubledash && return
> > This line is superfluous, because 'git describe' does not have any path
> > arguments.
>
> Yup. Aside from the two items described above (mising SOB line
> and the unnecessary double dash test) this patch looks fine.
I suppose you're right. It does (empirically) attempt to parse
anything following a -- as a revision argument, but similar commands
like cherry-pick don't handle the -- specially either.
I'll resend a fixed version.
- Thomas
--
Thomas Rast
trast@xxxxxxxxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.
