SZEDER GGGbor <szeder@xxxxxxxxxx> wrote: > On Fri, Jul 25, 2008 at 12:02:50PM +0200, Thomas Rast wrote: > > --- > Signed off by? > > > _git_describe () > > { > > + __git_has_doubledash && return > This line is superfluous, because 'git describe' does not have any path > arguments. Yup. Aside from the two items described above (mising SOB line and the unnecessary double dash test) this patch looks fine. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html