On Thu, 24 Jul 2008, Johannes Schindelin wrote: > > From: Björn Steinbrink <B.Steinbrink@xxxxxx> > > When index-pack completes a thin pack it appends objects to the pack. > Since the commit 92392b4(index-pack: Honor core.deltaBaseCacheLimit when > resolving deltas) such an object can be pruned in case of memory > pressure. > > To be able to re-read the object later, a few more fields have to be set. > > Noticed by Pierre Habouzit. > > Hopefully-signed-off-by: Björn Steinbrink <B.Steinbrink@xxxxxx> > Hopefully-reviewed-and-signed-off-by: Nicolas Pitre <nico@xxxxxxx>, > > -- > > This was probably missed in the flurry of patches, scratched > patches, and new patches. > > Nico could you have a quick look? (I would ask Shawn, but I know > that he is pretty busy with real world issues.) sorry, I have intermitant connectivity this week, and I'll be off the net for two weeks after that. Yes, this looks fine, although I'd add a comment mentioning that those extra fields are uninitialized in the thin pack case when objects are appended to the pack since they're already initialized otherwise. ACK. Nicolas
