Stephan Beyer wrote: > Well, I've seen that *a lot* of lib code (15 functions, see below) is in > the builtins. > > Cleaning that up seems to be good to have a real separation between > libgit and builtins, but I guess such a change would not find its way > into 1.6.0, would it? > > Regards, > Stephan > > PS: I've spontaneously decided to make a list: > > defined-in func-name - used in builtin-\1.c Of course my list was not complete. (My regex was too simple.) I add some: > builtin-add.c: > add_files_to_cache() - add, checkout, commit > interactive_add() - add, commit > > builtin-archive.c: > parse_pathspec_arg() - archive, upload-archive parse_treeish_arg() - archive, upload-archive parse_archive_args() - archive, upload-archive builtin-commit-tree.c: commit_tree() - commit-tree, merge builtin-fetch-pack.c: fetch_pack() - also used in transport.c > builtin-init-db.c: > init_db() - init-db, clone > > builtin-ls-files.c: > overlay_tree_on_cache() - ls-files, commit > report_path_error() - ls-files, checkout, commit pathspec_match() - ls-files, checkout, commit > builtin-mailsplit.c: > read_line_with_nul() - mailsplit, mailinfo > > builtin-merge-recursive.c: > write_tree_from_memory() - merge-recursive, checkout merge_trees() - merge-recursive, checkout merge_recursive() - merge-recursive (used nowhere else) > builtin-prune-packed.c: > prune_packed_objects() - prune-packed, prune builtin-send-pack.c: send_pack() - also used in transport.c > builtin-shortlog.c: > shortlog_add_commit() - shortlog, log > shortlog_init() - shortlog, log > shortlog_output() - shortlog, log > shortlog_init() - shortlog, log > > builtin-stripspace.c: > stripspace() - stripspace, commit, tag > > And launch_editor() that is handled by the patch in this thread. So keep everything or is it worth splitting that somehow up? Regards. -- Stephan Beyer <s-beyer@xxxxxxx>, PGP 0x6EDDD207FCC5040F -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
