Petr Baudis <pasky@xxxxxxx> writes: > um, oops. I actually never got to know these by heart since I learnt > to expliciply group the expressions early on. I guess my only excuse is > that I've stumbled at 0bdf93cbf earlier and understood it the _wrong_ > way around since I'm getting really sleepy. ;-) > > I still think my change improves the code readibility so it could be > kept, but I'm fairly neutral on this. I cannot be neutral when a patch introduces unnecessary fork. The quality of shell scripts in git.git seems to have deteriorated over time but I do not think we would want to spend too much maintainer time to go back and fix all of them. Please don't make things worse, at least. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
