Hi, On Wed, 23 Jul 2008, Petr Baudis wrote: > Commit 46eb449c restricted git-filter-branch to non-bare repositories > unnecessarily; git-filter-branch can work on bare repositories just > fine. I think this is fine. > This also fixes suspicious shell boolean expression during a check > for dirty working tree. If you are talking about X && Y || Z, it is well established (and should not be suspicious to a shell hacker like the creator of Cogito) that Z is executed if either X fails, or X succeeds and Y fails. > +test_expect_success 'rewrite bare repository identically' ' > + (git config core.bare true && cd .git && git-filter-branch branch) > +' > +git config core.bare false Any reason why this is done outside the test? Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html