Hi, On Wed, 23 Jul 2008, Dmitry Potapov wrote: > On Tue, Jul 22, 2008 at 10:56:04PM +0100, Johannes Schindelin wrote: > > > > When a file's crlf attribute is explicitely set, it does not make > > sense to ignore it, just because the config variable core.autocrlf has > > not been set. > > Hmm... About a week ago, I was about to propose the same change, but > after reading documentation and some thinking I was not able to convince > myself that this change would be the right thing to do. Well, I have a shared repository, where I set the attribute. Now, every once in a while, people check in text _with_ CR/LF. Yes, that is right, I marked it explicitely as crlf, yet I am on the whim of the people choosing to set the config variable or not. And I could not care less what the documentation says: if it does not make sense, it does not make sense. > > +test_expect_success 'attribute crlf is heeded even without core.autocrlf' ' > > s/heeded/needed/ Nope. "heeded" is what I meant. I am not a native speaker, so this could be wrong. But "needed" is not what I meant (the sentence would not make sense with "needed"). Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html