Dmitry Potapov <dpotapov@xxxxxxxxx> wrote: > On Sat, Jul 19, 2008 at 06:27:36PM -0700, Junio C Hamano wrote: > > > > So what's the conclusion of this issue? > > > > I'll just revert 2fe403e (git-svn.perl: workaround assertions in svn > > library 1.5.0, 2008-07-06) for 1.6.0-rc0 unless I hear better > > suggestions. > > I have tested the change that I proposed, and it seems to solve the > problem and, as far as I can tell, no other correction is necessary. > Yet, I don't really understand git-svn well, so I could be wrong. > > Reverting 2fe403e will only help users of svn library 1.4, while all > new linux distributives, which will include Git 1.6.0, are going to > install svn library 1.5.0, and if you use svn library 1.5.0, reverting > 2fe403e does not fix anything but only add one more bug. Thus, unless > we are going to require to install git-svn only with svn library 1.4, > reverting this change does not seem to be very helpful for most users. > > So, I hope my patch is better solution... > > Dmitry Thanks Dmitry, Your patch works for me on 1.4.3, so if it works with 1.5.0, consider it: Acked-by: Eric Wong <normalperson@xxxxxxxx> -- Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
