Re: [PATCH] fix "git-submodule add a/b/c/repository"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano wrote:
Thanks.

The above is quite a bit more information than I can read from
Documentation/git-submodule.txt; care to send it in in a patch form?

Will do, but I think it makes more sense to clean things up a bit so they are more explicable:

1) *require* two arguments for add: <URL> <relative-path-in-repo>
2) Remove one option for URL. Currently, we accept:
   a) absolute URL : origin is at URL
b) top-level-relative URL (./foo | ../foo) : locates origin relative to top-level origin c) path-relative URL : locates origin relative to current working directory

I don't understand the use-case for item (c), and in any case it is easily replaced as an abolute url (e.g., $(pwd)/URL). So, I propose to restrict to (a) or (b) only, and reject (c).

I think these two changes in concert will reduce a lot of confusion without removing any real capability. Absent negative comments, I will prepare a patch to do this, *and* update the documentation to better define the options.

Mark
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux