> > +test_expect_success 'adding an already-existing repository deep in the directory hierarchy' ' > > + > > + mkdir dir0 && > > + mkdir dir0/dir1 && > > + git clone init dir0/dir1/init && > > + git-submodule add dir0/dir1/init && > > + git-submodule status | grep "dir0/dir1/init" > > +' > > I am not sure if this is fixing a sane use case. "submodule add" is > documented to take: > > 'git submodule' [--quiet] add [-b branch] [--] <repository> [<path>] > > and you are adding at dir0/dir1/init a submodule that will interact with "init" > repository, so shouldn't that command line be something like: > > git submodule add init dir0/dir1/init git submodule add dir0/dir1/init Is supposed to add the repository already checked-out in dir0/dir1/init as a submodule, at the same location. git submodule add init dir0/dir1/init Would clone dir0/dir1/init at ./init and add ./init as a submodule. This is actually what the current git-submodule (wrongly) does. Sylvain -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html