On Tue, Jul 08, 2008 at 11:18:37PM +0000, Shawn O. Pearce wrote: > Junio C Hamano <gitster@xxxxxxxxx> wrote: > > SZEDER Gábor <szeder@xxxxxxxxxx> writes: > > > + c=$((++c)) > > > > This assignment is somewhat curious, although it should work as expected > > either way ;-) > > I agree, its damned odd. But we already do this in the same > sort of loop inside of _git_branch() (see around line 541 in > next). This new patch is only sticking with our current set > of conventions in the script, so I say its fine. Well, according to git blame contrib/completion/git-completion.bash |grep '++' you started this convention back in 2006, I just copied and modified your code (; Maybe an old C++ "heritage"? In C++ it matters for class types (e.g. iterators), because the postfix operator might be slower than the prefix. Best, Gábor -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
