Junio C Hamano <gitster@xxxxxxxxx> wrote:
> SZEDER Gábor <szeder@xxxxxxxxxx> writes:
>
> > Hope that I got the commit message right (;
>
> It was very readable. Thanks.
Acked-by: Shawn O. Pearce <spearce@xxxxxxxxxxx>
> > +__git_has_doubledash ()
> > +{
> > + local c=1
> > + while [ $c -lt $COMP_CWORD ]; do
> > + if [ "--" = "${COMP_WORDS[c]}" ]; then
> > + return 0
> > + fi
> > + c=$((++c))
>
> This assignment is somewhat curious, although it should work as expected
> either way ;-)
I agree, its damned odd. But we already do this in the same
sort of loop inside of _git_branch() (see around line 541 in
next). This new patch is only sticking with our current set
of conventions in the script, so I say its fine.
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
