On Wed, Jun 25, 2008 at 02:53:41PM -0400, Nicolas Pitre wrote: > On Wed, 25 Jun 2008, Mike Hommey wrote: > > > On Tue, Jun 24, 2008 at 09:59:06PM -0700, Junio C Hamano wrote: > > > Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > > > > > > > On Wed, 25 Jun 2008, Nicolas Pitre wrote: > > > >> > > > >> Git older than version 1.5.2 (or any other git version with this option > > > >> set to 1) may revert to version 1 of the pack index by manually deleting > > > >> all .idx files and recreating them using 'git index-pack'. Communication > > > >> over the git native protocol is unaffected since the pack index is never > > > >> transferred. > > > > > > > > Rather than talk about when it does _not_ matter, wouldn't it be better to > > > > talk about when it _can_ matter? > > > > > > > > Namely when using dumb protocols, either http or rsync, with the other end > > > > being some ancient git thing (and it is worth mentioning version of what > > > > counts as 'ancient' too, I can't remember, probably means that pretty much > > > > nobody else can either). > > > > > > I agree with you that the description of the change (in the commit log) > > > and the instruction (in the documentation) could be more helpful and > > > explicit. > > (...) > > > > Wouldn't it be a good idea to add a warning in git update-server-info > > when it detects pack.indexVersion is not 1, too ? > > That would give the idea that index v2 is not good, while what we want > is to encourage everyone to move to index v2 ASAP. The warning could just say that people with older git won't be able to clone over dumb protocols. Nothing more. Mike -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
