On Tue, 24 Jun 2008, Junio C Hamano wrote: > For the other "usedeltabaseoffset" change, I think the insn in the > documentation Nico added is reasonable: > > + By default, linkgit:git-repack[1] creates packs that use > + delta-base offset. If you need to share your repository with > + git older than version 1.4.4, either directly or via a dumb > + protocol such as http, then you need to set this option to > + "false" and repack. Access from old git versions over the > + native protocol are unaffected by this option. > > except perhaps that the "set false and repack" should be clarified > further, perhaps like: > > ... then you need to set this option to "false" and repack using > git that is newer than (and including) v1.5.0. Actually the first release to support this is v1.4.4 not v1.5.0. > I am basing the above 1.5.0 on description of b6945f5 (git-repack: > repo.usedeltabaseoffset, 2006-10-13). $ git describe --contains b6945f5 v1.4.4-rc1~77^2~2 > On the "indexVersion" change, the documentation reads: > > pack.indexVersion:: > Specify the default pack index version. Valid values are 1 for > legacy pack index used by Git versions prior to 1.5.2, and 2 for > the new pack index with capabilities for packs larger than 4 GB > as well as proper protection against the repacking of corrupted > + packs. Version 2 is the default. Note that version 2 is enforced > + and this config option ignored whenever the corresponding pack is > + larger than 2 GB. > > which lacks the recovery insn (and it is int strictly the fault of this > patch, but we should have done this when we introduced the v2 idx). I > think a separate paragraph after the above would be necessary and > sufficient: > > If you have an ancient git that does not understand the version 2 > `*.idx` file, cloning or fetching over a non native protocol > (e.g. "http" and "rsync") which will copy both `*.pack` file and > corresponding `*.idx` file from the other side may give you a > repository that cannot be accessed with your old git. If the > `*.pack` file is smaller than 2 GB, however, you can use > `git-index-pack` on the `*.pack` to regenerate the `*.idx` file. Looks fine to me. Will you amend the patches or do you want me to repost them? Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
