On Mon, 23 Jun 2008, Junio C Hamano wrote: > > Hmm, we have quite a few calls to mkstemp(), so adding the workaround to > this specific call site does not scale well as a fix, I am afraid. All other callers of mkstemp() always rewrite the _entire_ path and don't care about the result after failure (since it failed) The new 'create_tmpfile()' usage was/is special in that it re-uses the path without recreating it all, just the final part. So I think Patrick's patch is fine and sufficient. Maybe I missed some in my quick grep, but it does look ok, and the create_tmpfile() usage really was pretty special. Linus -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
