Pierre Habouzit <madcoder@xxxxxxxxxx> writes: > Though I didn't fixed the fact that parse_options clobbers argv[0], > which can be easily fixed. The issue with that is that _some_ callers > use the fact that the filtered argv is NULL terminated. Isn't it just the matter of (1) leave argv[0] as is, (2) start copy dest at argv[1] not argv[0], and (3) terminate argv[nargc] = NULL where nargc is what you did not handle? You have argc args in incoming argv[], you consume zero or more of them starting from argv[1] up to potentially argv[argc-1] (and argv[argc] is NULL). So why is it an issue? Sorry, I do not understand. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
