Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > That builtin-blame option parsing is really ugly,... Yeah, but wasn't it because it needed to be compatible with both annotate syntax and rev-list style "range" notation at the same time? > +static int blame_bottomtop_callback(const struct option *option, const char *arg, int unset) > +{ > + const char **bottomtop = option->value; > + if (!arg) > + return -1; > + if (*bottomtop) > + die("More than one '-L n,m' option given"); > + *bottomtop = arg; > + return 0; > +} Hmmmm. I actually wanted to eventually allow more than one -L so that we can blame two functions inside a file, for example. Would this make it even harder, I have to wonder... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html