Junio C Hamano wrote:
> しらいしななこ <nanako3@xxxxxxxxxxxxxx> writes:
>
>> I apologize for my lack of perfect foresight as the original
>> author of the command. As I already said, I think expiration
>> period of reflogs that is configurable for each ref as suggested
>> earlier by Junio makes sense.
>
> You do not need to be overly apologetic.
I whole-heartedly second this.
> ... the
> way for them to thank you would be to scratch their own itch by filling
> the remaining 10% to make it work better in their context, not by bitching
> and quibbling on what the dictionary definition of the word "stash" is.
I think you're being a little unfair here on two points:
1) I think it is a valid point that the name of the command and it's
subcommand "save" have contributed to the confusion by those who were
not involved in the implementation of the stash feature.
2) A patch _has_ been offered and there has been no discussion of the
merits of that patch, only on why the stash should be persistent or not.
You have suggested two alternatives, one (--keep) was not commented on
favorably by anyone, and the other was not really commented on at all.
Besides, the point (for those arguing it) was not that users should
have the option to keep stashes, it was that keeping stashes
_by_default_ is the option of least surprise and doing so modifies the
stash behavior to match user expectations. So up until now, there has
been no reason for anyone to offer any alternative patch, since "--keep"
is not satisfactory and per reflog expiration _alone_ does not solve what
people think the problem is (that stashes expire by default).
Your suggestion of per reflog expiration, along with a default
configuration of never for the stash reflog expiration, _does_ solve
the problem. Time will tell if this feature is useful outside of
controlling the stash reflog expiration.
-brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
