On Thu, Jun 12, 2008 at 09:29:27AM +0100, Chris Ridd wrote: >> Because the "$1" could contain character sequences that some 'echo' >> implementations mangle. > > Indeed. If $1 started with -n that might cause problems on some platforms. It's much worse than that. Any backslash sequence can be interpolated. 4b7cc26 (git-am: use printf instead of echo on user-supplied strings). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html