Marek Zawirski <marek.zawirski@xxxxxxxxx> wrote: > On Fri, Jun 6, 2008 at 3:24 PM, Robin Rosenberg > > > > I'm somewhat reluctant to reformatting patches though. > > Well, so should I remove these reformatting patches from series? (oouch!) > > Actually, when I ran into formatting problem, Shawn suggested that I may > format PackFile as he was also touching this file - I much appreciated > this idea. PackIndex* formatting is however my own invention. I'm in favor of reformatting, at least these two classes. Editing them without the formatting fixes is insanely annoying. But bulk reformatting all 118 files at once is nuts. I'd rather do it one file at a time, when we touch it, and especially if it is fairly stable and isn't being actively hacked on by others. > Isn't it somewhat annoying that formatting is inconsistent through > project (especially line width in some places)? And that I almost have > to block formatting shortcut to stop my pre-save/pre-commit habit?;) Yes. Yes it is. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
