On Fri, Jun 6, 2008 at 3:24 PM, Robin Rosenberg
<robin.rosenberg@xxxxxxxxxx> wrote:
A well defined set of enhancements with only minor nitpicks (in separate mails)
Nice to hear. I'll send v2 of these 2 patches (04 and 09) in a moment.
With a slightly less place for nitpicks, I hope.
I'm somewhat reluctant to reformatting patches though.
Well, so should I remove these reformatting patches from series? (oouch!)
Actually, when I ran into formatting problem, Shawn suggested that I may
format PackFile as he was also touching this file - I much appreciated
this idea. PackIndex* formatting is however my own invention.
So you assume that Eclipse 3.4 will just force us to submit new patches
with specified formatting, but keep old lines formatting untouched, am I
right?
Isn't it somewhat annoying that formatting is inconsistent through
project (especially line width in some places)? And that I almost have
to block formatting shortcut to stop my pre-save/pre-commit habit?;)
Thanks,
--
Marek Zawirski / zawir
marek.zawirski@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
