Hi, On Tue, 3 Jun 2008, Marek Zawirski wrote: > Johannes Schindelin wrote: > (...) > > You mean line-wrapping, right? Is there a different recommended > > column/line ratio for JGit than for Git? Because some of your later > > patches introduce lines longer than 80 columns/line. > > Not only line-wrapping in fact. egit/jgit use it's own eclipse > formatting template that define more than line-wrapping, even some > spaces in javadocs as you may have seen. > > Actually I don't know is it 80 columns/line (but I suspect it may be), > as I just use this formatter associated with project by simply pressing > some keyboard shortcut. Maybe I simply missed some formatting, which > patch do you mean? Some things however look strange after > auto-formatting. While it may even look ugly for somebody I wouldn't try > to change that by hand, to make other commiters lifes easier allowing > them also just press "format" button ;) Ah, thanks for the explanation! > > > Add getType() method to RevObject hierarchy > > > > Was the idea not to use instanceof to be able to have multiple "types" > > per object? I.e. a commit object is of type commit, but also of type > > object... > > I'm not sure whether I understand you, but probably it was not what you > mean. The only idea behind that was to refactor instanceofs to > polymorphic getType() calls. Actually, the result is no longer polymorphic, as every object can have only one type now. > It allows us mapping, indexing by type, using switches... without tones > of code. Hrm, I thought that you added more lines than you deleted. But hey, I do not really know what you want to index, maybe you got a point there. I guess I'll see ;-) Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
