Re: [JGIT PATCH 00/12] Extensions in core needed by PackWriter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 2 Jun 2008, Marek Zawirski wrote:

> Series start with formatting stuff, as some old files were not 
> appropriatelly formatted.

You mean line-wrapping, right?  Is there a different 
recommended column/line ratio for JGit than for Git?  Because some of your 
later patches introduce lines longer than 80 columns/line.

>   Add getType() method to RevObject hierarchy

Was the idea not to use instanceof to be able to have multiple "types" per 
object?  I.e. a commit object is of type commit, but also of type 
object...

BTW I really like the iterator implementation.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux