Re: [PATCH 4/3] bisect: use a detached HEAD to bisect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paul Mackerras <paulus@xxxxxxxxx> writes:

> Linus Torvalds writes:
>
>> Of course, _usually_ it's just the top commit, and it's obvious that way 
>> which one is the checked-out one, but if you do "gitk --all" or just 
>> generally have multiple branches, right now it's hard to see what commit 
>> is the checked-out one, regardless of whether it's detached or not.
>
> If it's not detached, the branch name is in bold, but evidently that's
> either not intuitive or not sufficiently distinct...
>
>> I think "HEAD" in a green box would solve that too, but on the other hand, 
>> we have a *lot* of boxes already. For people who mainly just track another 
>> repo, you already have one box saying "master", and another one saying 
>> "remotes/origin/master", and adding yet *another* box saying HEAD that 
>> just points to the same commit will work, but do we really want that?
>> 
>> I actually like the red circle for "Local uncommitted changes". Maybe we 
>> can use a similar visual clue for "currently checked out". You already 
>> picked green for the "added to the index" case, so we have the three 
>> primary RGB colors already used, but we could make it just be a deep 
>> yellow.
>> 
>> Of course, maybe people hate lots of colos already, and something more 
>> akin to the text background thing that we use for the selected commit 
>> would be better.
>> 
>> I dunno. There's so many options.
>> 
>> Here's a "make it yellow" patch.
>
> Thanks.  I have checked in something similar, that also handles the
> cases where you update the graph and the head has moved, and when you
> do a checkout or reset using the gitk menus.

Thanks.  Will pull, but it will have to miss upcoming 1.5.6-rc0,
unfortunately.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux