Re: [PATCH 4/3] bisect: use a detached HEAD to bisect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 24, 2008 at 09:14:21AM -0700, Linus Torvalds wrote:

> I actually like the red circle for "Local uncommitted changes". Maybe we 
> can use a similar visual clue for "currently checked out". You already 
> picked green for the "added to the index" case, so we have the three 
> primary RGB colors already used, but we could make it just be a deep 
> yellow.
>
> [...]
> 
> Here's a "make it yellow" patch.

I kind of expected this to color the _ref_, not the commit bubble. That
is, I think it is useful not just to see that "this commit is pointed to
by HEAD" but that "master is the currently checked out branch."

Of course in the case of detached HEAD, we would have only the commit to
color. But in that case a green box probably makes sense, since you
probably aren't going to have a bunch of other boxes pointing to it
(at most, a tag name or remote tracking branch name).

IOW,

  1. If head points to a ref, color the background of that ref box
     specially (yellow and green are taken. Red is probably a bit too
     danger-implying.  Blue?)
     ...
     Hmm, actually it looks like we already bold the refname in that
     case. I never noticed that until now. If I'm not the only one,
     then maybe that is an argument for making the differentiation more
     obvious.

  2. If head is detached, add a green 'HEAD' box.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux