On Tue, May 06, 2008 at 01:51:28AM -0400, Jeff King wrote: > So anyway, here is the less invasive version. > [of configurable paging] Gah. Lacking any more input, I was going to clean this up and re-submit, but it seems to fail some unrelated tests. It appears that with this patch, you can no longer do: cd .git && git show HEAD because of some awful ordering constraints in the wrapper. Specifically, looking in the config for pager.* entails calling git_path, which ends up calling setup_git_env, which says "I guess our git_dir is '.git'". Which is of course totally wrong, and calling setup_git_directory would find the right thing. So the logic in setup_git_env seems bogus, but should basically never be invoked because we do generally call setup_git_directory_gently before then. Either it should probably call setup_git_directory_gently (though I am afraid of what awful side effects that could have), or it should just barf, and people should do setup_git_directory beforehand (and I'm sure that will break something too). Blargh. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
