On Thu, May 01, 2008 at 11:19:49PM -0700, Junio C Hamano wrote: > Heh, I like it. I briefly thought that pager.cat-file may wreak havoc on > scripts, but our pager machanism should be clever enough not to, and > cat-file is a valid variable name in the configuration file format ;-). Yes, I sort of assumed that the pager "auto" setting would take care of most things. I guess somebody could be crazy enough to set pager to "always" and pager.mailinfo to "true", but I'm not sure that's worth avoiding. My bigger worry is that this affects only builtins. Which makes it sufficient for turning off the pager for anything that does USE_PAGER. But you can't turn _on_ the pager for arbitrary commands (e.g., pager.pull would be ignored). And some commands use pagers from sub-commands; e.g., git-stash calls git-diff to show a stash; so turning off the pager entails setting pager.diff, with no way to differentiate between stash and regular diff. So it would be inconsistent and expose implementation details. But maybe that is OK for now, and we just say "well, everything will become a builtin eventually." ;) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
